SOLR-18157: Optimize buffer allocation in JavaBinCodec#4208
Merged
psalagnac merged 2 commits intoapache:mainfrom Mar 19, 2026
Merged
SOLR-18157: Optimize buffer allocation in JavaBinCodec#4208psalagnac merged 2 commits intoapache:mainfrom
psalagnac merged 2 commits intoapache:mainfrom
Conversation
Implements a smarter allocation strategy using powers of 2 for the internal buffer of JavaBinCodec.
dsmiley
approved these changes
Mar 14, 2026
Contributor
dsmiley
left a comment
dsmiley
left a comment
There was a problem hiding this comment.
Nicely done Pierre!
I was about to suggest Lucene ArrayUtil.oversize for this but then realized that's not possible for SolrJ.
psalagnac
added a commit
that referenced
this pull request
Mar 19, 2026
Implements a smarter allocation strategy using powers of 2 for the internal buffer of JavaBinCodec. (cherry picked from commit f3fe28b)
psalagnac
added a commit
that referenced
this pull request
Mar 19, 2026
Implements a smarter allocation strategy using powers of 2 for the internal buffer of JavaBinCodec. (cherry picked from commit f3fe28b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18157
This implements a smarter allocation strategy using powers of 2 for the internal buffer of JavaBinCodec. The goal is to reduce the number of allocations.
Added a JMH benchmark suite to measure serialization performance with different batch sizes. I see a small improvement in throughput locally. I expect the impact to be slightly higher in JVMs with big heap for other reasons.